Skip to content

(Auras) Fix claimed Boss/Priority/Role debuffs leaking into the debuff row - #256

Open
Enf0 wants to merge 1 commit into
DanderBot:mainfrom
Enf0:fix/debuff-row-claimed-category-leak
Open

(Auras) Fix claimed Boss/Priority/Role debuffs leaking into the debuff row#256
Enf0 wants to merge 1 commit into
DanderBot:mainfrom
Enf0:fix/debuff-row-claimed-category-leak

Conversation

@Enf0

@Enf0 Enf0 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

BuildDirectDebuffFilters, category mode. When an Aura Designer debuff group
claims a category (Boss, Priority, etc.), the row correctly skips building
that category's own record — but the other four category records (CC, Raid,
Dispellable, Non-Player) never find out. Their exclusion list was built from
importantFlag/priorityDeclared, which only get set when this row
declares its own Boss/Role/Priority record. A fully claimed category has no
such record, so nothing tells the other four to leave it out.

Result: a debuff that's Boss- or Priority-flagged and also Dispellable, CC,
Raid-flagged, or mob-applied renders a second time on the bar, next to the AD
group already showing it. Hide Duplicate Debuffs doesn't hold for that case.
Show All mode isn't affected — it already subtracts straight from claimed
instead of reading back a declared record.

Fix: exclude boss/role/priority based on (checkbox on) OR (claimed), computed
independently instead of read back from what got declared. When nothing's
claimed this is identical to the old behavior, so unclaimed setups see no
change.

Checked every other read of importantFlag/priorityDeclared in the
function — nothing outside notImportant() touches them.

Verified with /df debug auras <unit>

AD group claiming Boss + Priority, row has Role/CC/Dispellable checked.

Before:

group 2 [cc]: HARMFUL|CROWD_CONTROL|!DISPELLABLE
    isRoleAura = false
group 4 [dispel]: HARMFUL|DISPELLABLE
    isRoleAura = false

After:

group 2 [cc]: HARMFUL|CROWD_CONTROL|!DISPELLABLE
    isRoleAura = false
    isBossOrRoleAura = false
    isPriorityAura = false
group 4 [dispel]: HARMFUL|DISPELLABLE
    isRoleAura = false
    isBossOrRoleAura = false
    isPriorityAura = false

Same delta on raid and nonplayer. Boss/Priority are now excluded from
every group they're claimed in, not just the one that no longer exists.

…categories

notImportant() only excluded boss/role/priority from the CC/Raid/Dispellable/
Non-Player records when this row's own Boss/Role/Priority record was actually
declared. A category fully claimed by an Aura Designer debuff group has no
such record (effBoss/effRole/priorityDeclared stay false), so the exclusion
never fired -- a claimed boss/priority debuff that also matched a still-
enabled category rendered a second time there, defeating Hide Duplicate
Debuffs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant