(Auras) Fix claimed Boss/Priority/Role debuffs leaking into the debuff row - #256
Open
Enf0 wants to merge 1 commit into
Open
(Auras) Fix claimed Boss/Priority/Role debuffs leaking into the debuff row#256Enf0 wants to merge 1 commit into
Enf0 wants to merge 1 commit into
Conversation
…categories notImportant() only excluded boss/role/priority from the CC/Raid/Dispellable/ Non-Player records when this row's own Boss/Role/Priority record was actually declared. A category fully claimed by an Aura Designer debuff group has no such record (effBoss/effRole/priorityDeclared stay false), so the exclusion never fired -- a claimed boss/priority debuff that also matched a still- enabled category rendered a second time there, defeating Hide Duplicate Debuffs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuildDirectDebuffFilters, category mode. When an Aura Designer debuff groupclaims a category (Boss, Priority, etc.), the row correctly skips building
that category's own record — but the other four category records (CC, Raid,
Dispellable, Non-Player) never find out. Their exclusion list was built from
importantFlag/priorityDeclared, which only get set when this rowdeclares its own Boss/Role/Priority record. A fully claimed category has no
such record, so nothing tells the other four to leave it out.
Result: a debuff that's Boss- or Priority-flagged and also Dispellable, CC,
Raid-flagged, or mob-applied renders a second time on the bar, next to the AD
group already showing it. Hide Duplicate Debuffs doesn't hold for that case.
Show All mode isn't affected — it already subtracts straight from
claimedinstead of reading back a declared record.
Fix: exclude boss/role/priority based on (checkbox on) OR (claimed), computed
independently instead of read back from what got declared. When nothing's
claimed this is identical to the old behavior, so unclaimed setups see no
change.
Checked every other read of
importantFlag/priorityDeclaredin thefunction — nothing outside
notImportant()touches them.Verified with
/df debug auras <unit>AD group claiming Boss + Priority, row has Role/CC/Dispellable checked.
Before:
After:
Same delta on
raidandnonplayer. Boss/Priority are now excluded fromevery group they're claimed in, not just the one that no longer exists.